[MERGE] BEncode Revision Serializer

John Arbash Meinel john at arbash-meinel.com
Thu Jun 4 16:34:43 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


...
>> val = [
>>  ('revision-id', rev.revision_id),
>> ...
>> ]
>>
>> That way, you can more accurately control the ordering of the values.
>>
>> Also, I think it should be tested with a lot more history than I tested
>> with. I only tested with 1k revs of mysql, so the difference could be
>> arbitrary.
> 
> For fields that are always present like the revision-id I'd consider
> just having a bencode list that stores them in a specified order.
> It's a bit less documenting but it will be smaller, faster, and let us
> control the order.
> 

That is what I ended up doing with the patch I proposed. As for "speed"
it wasn't particularly faster. Though I also added a little bit of
schema validation.

Given what Jelmer mentioned about the performance he saw in the past, I
might continue to play with the code a bit more, switching focus to the
Pyrex code itself.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkon6ZIACgkQJdeBCYSNAANxnwCggPDffm4HUeoMnTeP4vdl4JD0
OvUAoMS+43iMsqCf+/DTHy1s4RExuUdH
=ksia
-----END PGP SIGNATURE-----



More information about the bazaar mailing list