[MERGE] Fix for running parallel tests on Mac OS X

John Arbash Meinel john at arbash-meinel.com
Thu Jun 4 03:03:39 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Wed, 2009-06-03 at 06:13 -0400, John Szakmeister wrote:
>> +    except Exception, e:
>> +        pass 
> 
> This is faulty - it will hit ctrl-C. At minium you could fix it by doing
> except (KeyboardInterrupt, SystemExit):
>     raise
> except Exception:
>     pass
> 
> but better still would be to catch something more specific, like
> IOError.
> 
> bb:resubmit
> 
> -Rob

Actually, IIRC in python 2.5+ KeyboardInterrupt is no longer caught by
Exception. Still, I agree that (IOError, OSError), e: is probably better.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkonK3sACgkQJdeBCYSNAAMqfwCgph/eq9myQZUTmqfa0p2JTDhY
n78AoI0Psx+FGB8BqP4uCuwV3QcbRdtG
=Odcd
-----END PGP SIGNATURE-----



More information about the bazaar mailing list