Where does self.message get set on the Revision object?
John Szakmeister
john at szakmeister.net
Tue Jun 2 17:25:07 BST 2009
On Fri, May 29, 2009 at 9:35 AM, John Szakmeister <john at szakmeister.net> wrote:
[snip]
> Is it acceptable that Revision.message is None? FWIW, 'bzr log' shows
> "(no message)" on the same revision that kills qlog, so it appears
> that the command line tool can at least handle the fact that the
> message is None (although it doesn't appear call get_summary() by
> default, so it doesn't trigger that code path). It would probably be
> a good idea to document what attributes need to get added, and their
> constraints (if any).
Ping. It appears that at least portions of the code base allow for
Revision.message to be None, so I think get_summary() should get a
little smarter and make sure .message is not None before accessing it.
I just want verification of that before I create a patch.
> I'm also asking so I know where to submit a patch... either bzrlib or
> bzr-svn. :-)
...or qbzr.
-John
More information about the bazaar
mailing list