[MERGE] BEncode Revision Serializer

John Arbash Meinel john at arbash-meinel.com
Mon Jun 1 23:34:57 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> Hi John,
> 
...

> Is this with both the BEncode revision serializer and the BEncode
> Pyrex patch? I only saw the performance improvements with both.
> 
> Cheers,
> 
> Jelmer
It is with pt5 of the Pyrex patch, and the BEncode serializer.

I wonder if we could get the space savings back by moving away from the
Dict and instead using a list of lists. So instead of:

val = {
  'revision-id': rev.revision_id
...
}

you would have

val = [
  ('revision-id', rev.revision_id),
...
]

That way, you can more accurately control the ordering of the values.

Also, I think it should be tested with a lot more history than I tested
with. I only tested with 1k revs of mysql, so the difference could be
arbitrary.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkokV5EACgkQJdeBCYSNAAMQdwCeN+ubxgoNLDI7DVqhfEwJEaXR
a1IAn2kl0b6qDbJzIr15S1xWcNjvj561
=1eU+
-----END PGP SIGNATURE-----



More information about the bazaar mailing list