[MERGE] Clear the progress bar for cmd_ls before writing the output.
John Arbash Meinel
john at arbash-meinel.com
Mon Jun 1 16:45:59 BST 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Mattias Eriksson wrote:
> Just a small fix for cmd_ls to clear the progress bar before the output
> is written.
>
I would recommend changing this to:
+ ui.ui_factory.clear_term()
And making sure we have a:
from bzrlib import (
...
ui,
...
At the top of the file. While what you wrote probably works, it can
cause race conditions when we change import ordering. (Module
'bzrlib.foo' imports 'bzrlib.ui' before 'builtins.py' runs, but then we
restructure 'foo' and that no longer holds true, and suddenly 'bzr ls'
starts breaking because 'foo' changed.)
Otherwise, it looks good.
BB:tweak
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkoj97cACgkQJdeBCYSNAANCdwCfaQ/SlXYh1t7sabClCl/4AdMr
m4AAoIAHlDBvl83GxX2JnfXiSaBW7khT
=jsvA
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list