[MERGE] Add send format registry, pt 2

[Jelmer Vernooij]

On Tue, May 26, 2009 at 05:58:29PM +1000, Ian Clatworthy wrote:
> Jelmer Vernooij wrote:
> > The attached patch addresses Ian's feedback on my "bzr send" format
> > registry patch. It moves cmd_send and cmd_bundle_revisions to a
> > separate file, and adds the format registry as
> > bzrlib.send.format_registry (rather than inside the cmd_send class).
> This is closer but still doesn't have the layering I was looking for.
> Sorry that I wasn't clear enough first time around about what I wanted. :-(

> bb:resubmit

> Let me try again. I think cmd_send() and cmd_bundle_revisions() ought to
> remain in builtins.py. I think cmd_send._run() should become a public
> API - send.send() - and that cmd_send.run() and
> cmd_bundle_revisions.run() ought to just call it. In other words, the
> core command shells including help and option delcaration remain in
> builtins.py while the logic, format_registry, _send_4() and _send_0_9()
> go in send.py. Make sense? If not, ping me on IRC and we'll discuss further.
What about the attached patch? It still uses BzrCommandError in a
couple of places and actually accepts the location to the branche
instead of the branch objects, which would make it a bit less usable
for GUI things, that might already have objects but on the other
hand, if we move that out of bzrlib.send back into bzrlib.builtins
then we end up with very few things in bzrlib.send.send.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: send-format-registry-3.diff
Type: text/x-diff
Size: 23592 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090526/3bec40f5/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090526/3bec40f5/attachment.pgp