[MERGE] Return BranchPushResult instance from lossy_push() and make dpush print

Jelmer Vernooij jelmer at vernstok.nl
Thu May 14 22:10:44 BST 2009


Hi John,

On Thu, May 14, 2009 at 09:08:29AM -0500, John Arbash Meinel wrote:
> Jelmer Vernooij wrote:
> > dpush so far didn't print any output. This patch makes it use the same
> > mechanism as pull() and push() by having it return a BranchPushResult,
> > which contains a report() method that can print the results.

> This really seems like something that we need per-branch tests on. That
> Branch.lossy_push() both does a reasonable thing, and returns an
> appropriate object.

> Even if it isn't per-branch, at least a direct test, rather than
> indirectly testing via run_bzr(...)
I've added some basic tests: one to make sure that lossy_push() raises
LossyPushToSameVCS between normal Bazaar branches and one that checks
the DummyForeignVCS implementation to do the right thing.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: interbranch-dpush-result2.diff
Type: text/x-diff
Size: 10937 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090514/9ee985d1/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090514/9ee985d1/attachment.pgp 


More information about the bazaar mailing list