[MERGE] Using unicode Windows API to obtain command-line arguments.(#375934)

John Arbash Meinel john at arbash-meinel.com
Thu May 14 15:29:42 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> John, I've decided to slightly rework function in win32utils.py re
> python.exe case, so I'm resubmit new patch.
> 
> I've attached new version of patch and the diff between old and new
> versions for convenience.
> 

I don't really prefer the temp variable here:
+    f = win32utils.get_unicode_argv     # special function or None
+    if f is not None:
+        get_unicode_argv = f

versus
if win32utils.get_unicode_argv is not None:
  get_unicode_argv = win32utils.get_unicode_argv

But it isn't a big deal. The issue is that it creates a
'bzrlib.osutils.f' as an accessible variable, which is a bit strange.

BB:approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoMKtYACgkQJdeBCYSNAAOVWwCgpjHKIiseChDL7uBCied71XRt
9S0AoLk/oVbvI2hExJ3Lp85WTXf09aQx
=Yvbu
-----END PGP SIGNATURE-----



More information about the bazaar mailing list