[MERGE] [RFC] Refactor plugin loading code

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> The attached patch refactors the plugin loading code a bit so we
> remember the suffix tuple when finding plugins so we can use it for
> loading them later. This saves a few stats, and will make it possible
> to load individual plugins in the future (this is what I hope to work
> on next).
> 
> The next step (and my next patch hopefully) will be supporting something like 
> "bzr --with-plugin /foo/bar/bla".
> 
> Cheers,
> 
> Jelmer
> 

BB:comment

I didn't do a full review, but I did notice that you changed the warning
about invalid plugin names. You left the regex check in, but now it just
raises a generic error. Rather then trying to give a more helpful
"plugin contains invalid characters, you may want to rename it to XXX".

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoLR5YACgkQJdeBCYSNAAPxugCgqbS3BJrLgc5DuarZxupBqZh+
XX4AoMRaqyqZyf1BoEFcNN5nJ6wxZivs
=8D0E
-----END PGP SIGNATURE-----