[RFC] Smoother upgrades

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
>>>>>> "Jelmer" == Jelmer Vernooij <jelmer at samba.org> writes:
> 
> <snip/>
> 
>     Jelmer> I think this operation is common enough to be
>     Jelmer> runnable after upgrade (but only if the upgrade was
>     Jelmer> successful).
> 
> The message displayed after upgrade can mention that, if it's
> only an option of upgrade you leave my use case (keep backup
> longer) out.
> 
>     Jelmer> If we separate them users might end up removing
>     Jelmer> backup.bzr in places where the upgrade was not
>     Jelmer> succesful and end up losing data.
> 
> I'm not sure I'm following you there, you want an upgrade option
> to delete the backup as soon as the upgrade is successful but
> then you worry about users deleting it in case of errors ?
> 
> I'd rather say that people who will blindly delete backup.bzr are
> more likely to use that upgrade option or any recommended
> command to delete it, no ?
What I mean is if you have a large number of bzr branches and you run
"bzr upgrade --recurse <path>" that will upgrade a lot of bzrdirs. Some
of these upgrades may fail, in which case you really need the
backup.bzrdir directory.

If you run "bzr clean --recurse" or something afterwards you may end up
deleting precious data (since it's only in backup.bzrdir, and 'bzr clean
- --recurse' doesn't know which upgrades went successfully).

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iJwEAQECAAYFAkoLBlYACgkQDLQl4QYPZuXnBAP9EhiIlu4s/c8uZhF/aiYZVUpp
x0q5Z+WvJQN9fgs1MWcmSmdwaHzIJa2xLn//GfBrR4aoYs86GTNubf0yC369tz4B
LSm9bheMC781Anq6wg4fjw7REZzSIhim6LfCAfTb9iXI2b7yWVEigk0gdKaRjAh+
388w9FubzZN6ECd+Xpw=
=9RZ3
-----END PGP SIGNATURE-----