nested trees design-approach : composite trees vs iter_changes
Aaron Bentley
aaron at aaronbentley.com
Tue May 5 03:13:39 BST 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins wrote:
> On Tue, 2009-05-05 at 09:32 +1000, Robert Collins wrote:
>
>
>> CompositeTree worries me for a number of reasons.
>
> I should note that this *isn't* a quality of code issue - another reason
> I felt that I shouldn't veto.
If it were a quality-of-code issue, you should vote 'resubmit'.
'reject' is for when you don't want any change of this nature made to
the codebase.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkn/oM0ACgkQ0F+nu1YWqI1B1wCfanik6Kbvrtct2ALFgGKvhGj/
eXkAniIZ5DEb5teXC1FtWLHuuZyrdDbr
=UlPx
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list