[MERGE] [BUG 363837] Catch _win32_delete_readonly failure to remove file or directory and try to recover

Alexander Belchenko bialix at ukr.net
Sat May 2 07:50:37 BST 2009


martitzam at gmail.com пишет:
> This patch is for bug 363837.  Both that bug and this patch are limited
> to the win32 layer.
> 
> The patch results in bazaar giving windows at most two second chances
> (after delays of 250 ms) to delete a readonly file or directory, such as
> typically appear during external diff tools.

You have modified base behavior of delete on win32. I think it's the wrong approach.
Instead you'd better catch the error in the place where it occurs an print fine error message.

> 
> Also the generic exception has been replaced with a BzrError to make
> persistent failures easier to understand.
> 
> Martitza
> 




More information about the bazaar mailing list