[rfc] time to switch to Launchpad reviews

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> Code Review's advantages
...
>> - More reliable
> ^- As in, Launchpad doesn't crash as often?

Yes.

> Do we know if the email
> interface gets as easily confused as the bug submission one? (I often
> have new at bugs... give me failure bounces because I get some sort of
> syntax wrong.)

The syntax is the same as the syntax for bugs, because while I'm not a
great fan of the bugs syntax, I went for consistency.

That said, actually creating a merge proposal requires no commands at
all-- just send a reasonable merge directive to merge at code.launchpad.net.

>> Bundle Buggy advantages
>> - Maps tightly to Bazaar project's workflow
>>  - merge request status is determined fully automatically
>>  - no need for public branches
>> - Can represent a cherrypick (e.g. submitting multiple threads from a
>>   loom in parallel)
>> - Integrates cleanly with existing mailing lists
>> - Accepts patches
>> - Nicer email command syntax
>> - Autodetection of superseded merge requests
> 
>  - Provides a nice 'this patch has landed' message
>  - Already sorts into my 'bzr' folder because the mail goes to the same
>    list. I tried looking at the headers and found:
> 
> X-Launchpad-Project: bzr
> ^- Might be enough to sort on, though I'm guessing

Ought to be, yes.

> 
> Reply-To: mp+5861 at code.launchpad.net

email about merge proposals will always match Reply-To:
mp\+[0-9]+\@code\.launchpad.net

> Message-Id: <20090424134019.14170.96598.launchpad at loganberry.canonical.com>
> X-Launchpad-Message-Rationale: Subscriber @bzr
> X-Launchpad-Branch: ~bzr/bzr/trunk
> ^- again a maybe, doesn't seem particularly great (mabye everything in
> X-Launchpad-Branch:.*/bzr/.* ?

That's more or less equivalent to sorting on X-Launchpad-Project.
Source-package branches have longer URLs that could theoretically
contain "bzr" without being related to bzr.

> To: John A Meinel <john at arbash-meinel.com>
> ^- All emails from LP are sent *directly* to me, and not to a generic
> group (~bzr).

But see the rationale for why it was sent to you.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknx8aEACgkQ0F+nu1YWqI34yQCeIGHxiptfzi+BJBq+qbV+1Tj7
Lg0An2OC/L2UQv/Mr5+1f6XQ5/P9fkhr
=VVM4
-----END PGP SIGNATURE-----