[rfc] time to switch to Launchpad reviews

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Any comments, particularly from people who're participating in
> development or review at the moment?

I think Launchpad code reviews and Bundle Buggy are (at last) in a state
where both are reasonable choices.

Code Review's advantages
- - Submitters can request particular reviewers
- - Integrated with Launchpad
 - Can use LP teams
 - Can create a branch on Launchpad from an emailed merge directive
 - Planned: provide an alternative mechanism for landing patches
- - Provides a virtual mailing list and web forum for each submission
- - Optional Merge Analysis Daemon can provide preview diffs that detect
  merge conflicts
- - More reliable

Bundle Buggy advantages
- - Maps tightly to Bazaar project's workflow
 - merge request status is determined fully automatically
 - no need for public branches
- - Can represent a cherrypick (e.g. submitting multiple threads from a
  loom in parallel)
- - Integrates cleanly with existing mailing lists
- - Accepts patches
- - Nicer email command syntax
- - Autodetection of superseded merge requests

Code reviews finally support converting bundles into branches, which I
felt was a major missing piece.  Unfortunately, it will silently discard
merge directives whose target URL has a trailing slash:
https://bugs.launchpad.net/launchpad-bazaar/+bug/318040

> If there are no blockers I propose that we change the standard
> practice to posting merge proposals rather than to BB, leave BB
> running as a backup, and then if that goes well change the normal
> practice across.

I don't understand the difference between the "change the standard
practice" part and the "change the normal practice" part.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknxwCsACgkQ0F+nu1YWqI0GTwCcDKRiKSbljABA0Ejj19wjdH1p
FlIAnjdHN4olERVakAyoxCId7ZiMyiP8
=qRT7
-----END PGP SIGNATURE-----