[MERGE][BUG #364900] Fix bug in Python Groupcompressor
John Arbash Meinel
john at arbash-meinel.com
Wed Apr 22 00:57:42 BST 2009
-----BEGIN PGP SIGNED MESSAGE-----
I just tracked down a bug in the pure-python groupcompress code.
Basically, if you had a copy > 64kB long, it would issue multiple copy
commands (as it should), but they would all be 64kB requests (so the
last one would always be too long).
The patch is actually pretty small, though I updated the test suite a
bit while debugging this, and it seemed reasonable.
We can bring this into 1.14 if we want, since it is a critical problem
with using the pure-python implementation of groupcompress. That said it
isn't strictly a regression, and most people experimenting should
compile anyway, since it results in a *much* better experience.
(Converting 1k revs of MySQL takes something like 3-5min with
extensions, and 30+min without.)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the bazaar