[MERGE] Nested trees: misc
Aaron Bentley
aaron at aaronbentley.com
Tue Apr 14 13:56:07 BST 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins wrote:
> On Tue, 2009-04-07 at 14:21 -0400, Aaron Bentley wrote:
>> + subtree = tree.extract('subtree-id')
>> + tree._write_inventory(tree.inventory)
>> + tree.add_reference(subtree)
>
> This is problematic - if you have to call _write_inventory externally to
> use tree.extract() correctly, then we're making _write_inventory
> de-facto public.
>
> Is the _write_inventory call needed?
No, it's old code that apparently isn't needed anymore.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAknkh+cACgkQ0F+nu1YWqI0SRgCeMvUuyCe+qiMVTI2ANe5/w9qN
2OMAn3whtmB3anZUAm0K54bp0pqN/u8S
=Y3ci
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list