[MERGE] Pass realm as a string rather than a one-tuple.
Jelmer Vernooij
jelmer at vernstok.nl
Sat Apr 11 13:05:06 BST 2009
Vincent Ladeuil wrote:
>>>>>> "Jelmer" == Jelmer Vernooij <jelmer at vernstok.nl> writes:
>>>>>>
>
> Jelmer> The attached patch fixes a bug in the way realm is
> Jelmer> parsed at the moment during Basic HTTP
> Jelmer> auth. Currently it ends up as a tuple because of the
> Jelmer> way it is parsed, but ideally it should of course be
> Jelmer> a string.
>
> The http prompt tests should have caught that one, but... python
> is too helpful, the prompt is built with:
>
> prompt += ", Realm: '%s'" % realm
>
> and it makes no difference here whether realm is a string or a
> tuple of length 1.
>
> Jelmer> We should ideally add a test for this, but I was
> Jelmer> unsure about *where* this would have to be done.
>
> The attached patch adds such an explicit test.
Thanks!
bb:approve
Cheers,
Jelmer
More information about the bazaar
mailing list