[MERGE][RFC] Support *no authors* for a commit

James Westby jw+debian at jameswestby.net
Fri Apr 10 00:33:17 BST 2009


On Fri, 2009-04-10 at 01:24 +0200, Jelmer Vernooij wrote:
> Subversion and cvs2svn will occasionally create commits that have no
> committer or author set (e.g. commits not made by humans but "padding"
> commits).  bzr-svn will in this situation happily set the committer
> field to None and Bazaar deals with this just fine. However, the new
> Revision.get_apparent_authors() function will in this situation return
> [None].
> 
> Despite the fact that it's not generally a good idea to have the
> committer field set to None (robots have identities, too!) I think it
> should return [] rather than [None] so e.g. GUIs or bzr log don't show
> an empty author field or traceback.

BB:approve, an empty list of identities seems like the right thing here.

Why do you set rev.committer in one test, but not the other?

Thanks,

James




More information about the bazaar mailing list