[MERGE] Nested trees: CompositeTree
Aaron Bentley
aaron at aaronbentley.com
Wed Apr 8 14:29:53 BST 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Ian Clatworthy wrote:
> Ian Clatworthy has voted comment.
> Status is now: Semi-approved
> Comment:
> I'm part way through reviewing this. All the modifications look fine to
> me. There are no tests for CompositeInventory - I gather the feeling is
> that it's being tested indirectly through CompositeTree.
Right.
> I'm OK with
> that but think it's worth renaming CompositeInventory to
> _CompositeInventory to reflect it's private-use status.
That sounds fine to me.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkncptAACgkQ0F+nu1YWqI33DACfXb2otz5GZ7QsXsGZ8vbsFkbS
KosAniRANEndUcgIA8nBHZBpHpjDUuKd
=hSow
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list