[MERGE][1.14] Fix bug #355454 by casting to unicode.

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> This fixes the problem encountered by Bob while preparing the
> 1.14rc1 release.
> 
> I'm a bit surprised that we need to use absolute paths here since
> the call sites should be mainly dirstate where relative paths
> should be cheaply available and may avoid that double handling.
> 
> Anyway, this was blocking the release so we may work on a better
> fix later.
> 
>     Vincent
> 
> 

BB:comment

I think this is probably the wrong fix, but I'm not 100% so I'm
commenting rather than resubmitting.


If someone is passing in an abspath that isn't Unicode, then the caller
is not transmitting a proper path.

*paths* in memory should be unicode objects. The fix you supplied here
will break when whatever is calling this function supplies an encoded
string that has non-ascii characters.

I might be wrong, but I *think* this is exposing a bug in whoever is
calling these functions.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknbdtwACgkQJdeBCYSNAANOzQCcDCG3hXVeMRws07I0Sqnl4luV
NyQAn3SLoFNgCfsBSA3AbIuolbyvWnEr
=zd+j
-----END PGP SIGNATURE-----