[MERGE] Hide the transport direction in the progress bar if it is unknown.

[Jelmer Vernooij]

John Arbash Meinel wrote:
> Aaron Bentley wrote:
> > Matthew D. Fuller wrote:
> >> On Tue, Apr 07, 2009 at 10:31:00AM +0200 I heard the voice of
> >> Jelmer Vernooij, and lo! it spake thus:
> >>> I don't think there is a particular value in showing we don't know
> >>> something.
> >> I agree.
> > Well, in the general case, the value of telling the user we don't know
> > something is that then the user understands why we aren't telling them
> > something.
>
> > Aaron
>
> I don't have a big opinion on the ? versus X versus a blank space. My
> specific concern, though, is that we not change the width of the display.
The attached patch fixes the width issue.
> Consider branching from SVN into a bzr+ssh:// branch (such as doing a
> pull in a checkout). At that point, some of the time we will put up < or
> > for the bzr+ssh data, but then remove it for the SVN traffic activity.
>
> So I don't really care what you put up there, but I would ask that you
> put something rather than changing the width.
>
> And if there is going to be a blank space anyway, it would seem
> reasonable to put some sort of indicator...
The problem is that it may not be obvious what the "?" is saying
exactly. There are some apps that use a question mark in their progress
bar when the transfer is stalled to indicate that the reported
speeds/ETA are not necessarily correct anymore. X or = or >< makes more
sense to me (indicating bidirectional traffic).

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hide-unknown-directions.diff
Type: text/x-patch
Size: 2542 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090407/399fd15d/attachment.bin