[MERGE] Add get_username() call to the UIFactory.

[Jelmer Vernooij]

Vincent Ladeuil wrote:
>>>>>> "Jelmer" == Jelmer Vernooij <jelmer at samba.org> writes:
>
>     Jelmer> Vincent Ladeuil wrote:
>     >>>>>>> "Jelmer" == Jelmer Vernooij <jelmer at samba.org> writes:>
>     Jelmer> TestUIFactory provides a custom implementation of
>     Jelmer> get_non_echoed_password(); making it provide a mock
>     Jelmer> implementation of get_username() that doesn't raise
>     Jelmer> NotATerminal seems kind of pointless as we would only
>     Jelmer> be testing the mock implementation, not the actual
>     Jelmer> one.
>     >>
>     >> That's a different issue.
>     >>
>     >> If you mean NotATerminal is tested nowhere, you've found yet
>     >> another hole in our test suite, feel free to provide more tests
>     >> but I don't require them at that point (a FIXME: will do :)
>
> So I sent a patch regarding NotATerminal, you may want to merge
> from it once it lands.
Here is an updated version with I think all the changes we discussed,
and with your prompt() fixes merged.

Cheers,

Jelmer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ui-username.diff
Type: text/x-patch
Size: 10791 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090403/60a65c32/attachment.bin