[MERGE] NotATerminal considered harmful

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


...

> I couldn't find a way to reliably simulate running without a terminal
> while running from a terminal while still making getpass.gepass believes
> it was running without a terminal (simulating isatty() is not enough
> since getpass() then uses termios tricks and 2.5 and 2.6 do that
> differently...) and I thought it wasn't really worth the effort because,
> in the end, people running bzr with no controlling terminals are
> unlikely to do so with branches requiring authentication, and if they
> do, they'll get a authentication error anyway (giving them a
> NotATerminal traceback is just hiding the real cause).
> 
>      Vincent

As long as the code is in CLIUI Factory or TextUIFactory so that guis
that don't have a terminal can still offer their prompts, this seems fine.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknWElAACgkQJdeBCYSNAAOSNQCfWLh+rN90AJUIWoi3CzBuQcwQ
8PwAn2w5GWDcD9/88miJGAoN3gxRYQQN
=NL8j
-----END PGP SIGNATURE-----