[MERGE] Stop-gap fix for Repository.get_revision_xml. (was Re: [MERGE] Don't use get_revision_xml when writing a bundle, instead get all the revisions together.)

[Andrew Bennetts]

Vincent Ladeuil wrote:
[...]
> 
>     Andrew> It also gets rid of the only use of get_revision_xml
>     Andrew> in bzrlib outside of cmd_cat_revision and the test
>     Andrew> suite.  I also tidied the implementation of
>     Andrew> get_revision_xml while I was glancing at it.
> 
> Not good :-(
> 
>   LANG=C ./bzr selftest -s bzrlib.tests.blackbox.test_non_ascii.TestNonAscii.test_cat_revision
> 
> succeeds (PQM setup striking again)
> 
>   LANG=en_US.UTF-8 ./bzr selftest -s bzrlib.tests.blackbox.test_non_ascii.TestNonAscii.test_cat_revision
> 
> fails miserably ;-(
> 
> The real fix being still a bit unclear (related to cStringIO
> encoding handling or its lack), the attached patch revert the
> get_revision_xml change.

Weird, but I see it too.

bb:approve

Thanks for the fix.

-Andrew.