[MERGE] Add get_username() call to the UIFactory.

[Jelmer Vernooij]

Jelmer Vernooij wrote:
> Vincent Ladeuil wrote:
>>>>>>> "Jelmer" == Jelmer Vernooij <jelmer at samba.org> writes:> 
>>     Jelmer> TestUIFactory provides a custom implementation of
>>     Jelmer> get_non_echoed_password(); making it provide a mock
>>     Jelmer> implementation of get_username() that doesn't raise
>>     Jelmer> NotATerminal seems kind of pointless as we would only
>>     Jelmer> be testing the mock implementation, not the actual
>>     Jelmer> one.
>>
>> That's a different issue.
>>
>> If you mean NotATerminal is tested nowhere, you've found yet
>> another hole in our test suite, feel free to provide more tests
>> but I don't require them at that point (a FIXME: will do :)
> Attached is an updated version that no longer uses NotATerminal and
> tests utf8, as we discussed on IRC.
Forgot the big fat NEWS item, since GUI's will have to implement a new
function now.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ui-username.diff
Type: text/x-diff
Size: 9870 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090401/b4637ab2/attachment-0001.bin