John Arbash Meinel
john at arbash-meinel.com
Wed Apr 1 03:06:08 BST 2009
-----BEGIN PGP SIGNED MESSAGE-----
Robert Collins wrote:
> In get_source, please upcall for the fallback; that prevents some
> duplication, and this isn't a high volume codepath.
> This comment
> + # Can we get this from the search?
> in get_stream seems redundant. Please either expand this to something
> concrete or remove it :)
Sorry, I actually did end up getting it from the search and forgot to
remove the comment. I was using:
However, the recipe has 'exclude_keys', which is what I used instead. I
assume that is correct.
> For testing, we do test fetch in per_repository; I think a better and
> more relevant test is to test the source type that is constructed - add
> an expected source type to the parameterisation for per_repository, and
> assert they match in a per_repository.test_fetch fetch.
Is this 'per_repository' or something more of an 'interrepository' test?
I agree that a simple test in 'test_fetch' is probably not entirely
relevant, though it was certainly the easiest to get at (at the time, at
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar