[MERGE] Make the test suite run under Python 2.7a0

John Arbash Meinel john at arbash-meinel.com
Wed Apr 1 02:58:49 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> John Arbash Meinel wrote:
> [...]
>> BB:approve
>>
>> Though I'll comment that you could have left TestCase.exc_info() and
>> just had it return sys.exc_info().
> 
> I could have, but what for?  Do you think users of bzrlib were using
> TestCase.exc_info directly?  It seemed reasonable to me to just delete the
> unnecessary cruft; it was always equivalent to calling sys.exc_info()
> anyway.

Just that there were a lot of cases that were using it that you had to
update, rather than updating 1 place.

> 
> Thanks for the review.  I've submitted the branch as-is; we can always
> restore TestCase.exc_info() before 1.14 if it turns out there's a reason to
> do so.
> 
> -Andrew.
> 

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknSylkACgkQJdeBCYSNAAObEwCg2cHgau/y4C8acF7+V8FLJRMW
zHsAn2uSKMROqqeyIjkZZAeMyXeye4ZN
=+2yl
-----END PGP SIGNATURE-----



More information about the bazaar mailing list