[brisbane:MERGE] GroupCHKStreamSource

Robert Collins robert.collins at canonical.com
Tue Mar 31 23:17:43 BST 2009


bb:tweak

In get_source, please upcall for the fallback; that prevents some
duplication, and this isn't a high volume codepath.

This comment
+        # Can we get this from the search?

in get_stream seems redundant. Please either expand this to something
concrete or remove it :)

For testing, we do test fetch in per_repository; I think a better and
more relevant test is to test the source type that is constructed - add
an expected source type to the parameterisation for per_repository, and
assert they match in a per_repository.test_fetch fetch.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090401/1fa406ad/attachment.pgp 


More information about the bazaar mailing list