brisbane: groupcompress cleanups - part1

[Ian Clatworthy]

I've spent the day doing a code review of groupcompress,
well the first 3rd of it at least. Attached are my proposed
code clean-ups. All tests (that passed before) still pass so
I'm pretty sure I haven't broken anything. OTOH, there's some
unanswered questions in XXX comments I've added that make it
worthy of a quick review by jam or lifeless before landing
these changes.

I'll continue reviewing the rest of groupcompress tomorrow.
After that, I'll work my way up the stack (chk_map, inventory)
getting the core pieces of brisbane-core acceptable (IMO) for
landing into bzr.dev.

A start,
Ian C.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: groupcompress-cleanups.patch
Type: text/x-diff
Size: 26321 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090331/0718833c/attachment-0001.bin