[MERGE] Fix InterBranch.pull tests.

[Jelmer Vernooij]

Robert Collins wrote:
> On Mon, 2009-03-30 at 23:31 +0200, Jelmer Vernooij wrote:
>   
>> Robert Collins wrote:
>>     
>>> bb:comment
>>>
>>> what does your svn puller do differently?
>>>   
>>>       
>> It only fetches Subversion tags since the last time that we pulled from
>> the remote branch (since finding tags sometimes has to analyze all
>> history)
>>     
>
> This is something I would like/be happy to see encoded into the stock
> bzr api's, even though bzr's current tags don't have this capability.
>   
ok
>>  and it avoids any calls that involve revno's of the remote
>> branch, as calculating revno's for svn branches requires walking the
>> full mainline history.
>>     
>
> ah. Now, lets see, why do we do that.. ah yes, we do it to get our new
> revno, and that's much of a muchness except when a very large pull is
> done - e.g. the initial pull of ooo.
>
> I suspect this might be better done with a flag on BranchFormat
> actually, and here is why...
>
> RemoteBranch is a proxy for branches held elsewhere. It can represent
> git or hg or svn branches too, if the plugins are on both systems; and
> for those cases you would still want to avoid asking for the source
> branch revno.
>   
I agree this would be nice too, but I think that should be independent
of this patch.

Other areas where SvnInterBranch.pull() helps:

 - returns a SubversionPullResult() which prints the svn revision number
that was pulled
 - doesn't have to do any access of the remote repository beyond finding
the latest revision number, as it doesn't need to find the remote
revision id, when the branch is up to date.

Cheers,

Jelmer