[MERGE] Don't raise KnownFailure for all coding_style regressions

John Arbash Meinel john at arbash-meinel.com
Mon Mar 30 14:34:44 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marius Kruger wrote:
> * Don't raise KnownFailure for all coding_style regressions, but be less strict.
> * Just print the number of files with trailing white-space in stead of
> failing (like the long-line check).
>   I timed the test with and without this and I think the difference is
> small enough to leave it in.
>     ==with trailing white-space & long-line checks==
>     Ran 1 test in 0.507s
>     real    0m3.136s
>     user    0m2.990s
>     sys     0m0.130s
>     ==without==
>     Ran 1 test in 0.366s
>     real    0m3.056s
>     user    0m2.930s
>     sys     0m0.130s
> * I updated the white space policy in HACKING to:
>   Trailing white space should be avoided, but is allowed.
>   You should however not make lots of unrelated white space changes.
> 
> --
> Marius
> # I only got round to this now because I've been a bit busy at work
> and over the weekends
> # and my internet at home has been down for most of march and still is :(
> 

BB:approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknQynQACgkQJdeBCYSNAAOSJgCdF/AusDfAEdvBrK4S6Ym51DWY
evgAniMvxi90/n2iGU2L2eilkP5rHIOg
=/Pjj
-----END PGP SIGNATURE-----



More information about the bazaar mailing list