[MERGE/RFC] Add transport jail to bzr smart server; add ignore_fallbacks option to BzrDir.open_branch
Vincent Ladeuil
v.ladeuil+lp at free.fr
Thu Mar 26 09:27:08 GMT 2009
>>>>> "robert" == Robert Collins <robert.collins at canonical.com> writes:
<snip/>
robert> Hooks are a clear separation of policy and functionality;
Key point, thanks.
Andrew> Robert Collins wrote:
>> On Thu, 2009-03-26 at 09:17 +0100, Vincent Ladeuil wrote:
>> >
>> > What I still don't get is why you use a per thread data instead
>> > of just a global one ? You have a use case where different jails
>> > are needed inside the same process ? Outside the test suite ?
>>
>> The server is multithreaded. Each thread gets jailed separately.
Andrew> To elaborate on this point: when you do “bzr serve”
Andrew> to create a TCP bzr server, bzr instantiates a
Andrew> bzrlib.smart.server.SmartTCPServer.
Pff, of course, silly me.
I still don't like it, but I have no alternative to propose :-)
Thanks for the explanations to both of you,
Vincent
More information about the bazaar
mailing list