[RFC] TreeTransform and 'iter_files_bytes()'

[Robert Collins]

On Tue, 2009-03-24 at 16:30 -0500, John Arbash Meinel wrote:


> Either that, or TT.create_file() should do:
> 
> if isinstance(content, str):
>   out.write(content)

>   out.writelines(content)
> 
> This is a rather huge difference for 'bzr co' times....
> 
> At least, I think that is the easier fix, rather than changing the api
> of "iter_files_bytes()" to return a 'chunked' format. Mostly because it
> is a more significant API change.
> 
> Thoughts?

I'd be incined to have TT do type(content) is str:, rather than require
chunked; OTOH if API docs for iter_files_bytes say that chunked is
valid, chunked may avoid some double handling with gc.

Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090325/d995ad05/attachment-0001.pgp