Brisbane failure Inventory has no attribute 'filter'

John Arbash Meinel john at arbash-meinel.com
Tue Mar 24 20:17:23 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Since Ian landed his "get the partial tree" part from Inventory.filter()
it is now causing test failures because CHKInventory doesn't support
filter().

I'm not sure how to fix this, because in my understanding, we *don't*
want to support filter() for CHKInventory. It was only done as a hack to
make "bzr log -v file" somewhat less horrid for XML inventories.

Ian, can you shed some light on what you were thinking brisbane-core
should do for "test_get_revision_delta_filtered"?

(It may just be that CHKRepository needs to re-implement
"get_revision_delta_filtered", and just call iter_changes(filter=XX)
rather than pre-filtering the inventory before doing that.)

I don't have a good idea of what you were thinking to get those tests
passing again, so I would appreciate your assistance.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknJP9MACgkQJdeBCYSNAAMmoQCgw0lt6J02083uxgwNparAFUva
VqIAnj75vtXUPcANlFzTJeVMzSwkg8e5
=rD9h
-----END PGP SIGNATURE-----



More information about the bazaar mailing list