[PATCH] convert SMTP user name and password to byte strings (bug 338261)

[James Henstridge]

On Tue, Mar 17, 2009 at 8:17 AM, James Henstridge <james at jamesh.id.au> wrote:
> Without any guidance on how character encodings should be handled
> here, I thought it safest to opt for the more conservative path.  If
> someone complains, we'll have some more information about what mail
> servers expect here.

So, I now agree that encoding to UTF-8 is the correct behaviour, so
that is what this updated patch does.

While the CRAM-MD5 authentication method makes no mention of character
encoding (which is one of the reasons people want to deprecate it),
the PLAIN authentication method specifies that the user name and
password are encoded in UTF-8.

So does this look okay to be merged?

James.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug-338261-v2.patch
Type: text/x-diff
Size: 6310 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090324/55f72ff6/attachment.bin