[MERGE] Delete faulty test that can leak a subprocess and/or hang the test suite.

John Arbash Meinel john at arbash-meinel.com
Fri Mar 20 17:09:01 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Sooo, a lot of concerns were raised here and a lot of problems
> were indeed present in both my patch and the existing tests.
> 
> I added the following doc-strings to better expose the tests
> intents:
> 
>     def test_breakin(self):
>         """Once called, the debugger can be exited and finishes the process."""
> 
>     def test_breakin_harder(self):
>         """SIGQUITting twice ends the process."""
> 
> 
> Then, during yet another long painful testing/debug session, I
> realized that:
> 

BB:approve

I think this is a reasonable tradeoff, especially for "effort to
maintain code X". Interprocess communication is a bit tricky if they
aren't explicitly trying to do the right thing.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknDza0ACgkQJdeBCYSNAAPOIwCgj8w3nyu+ictTitpRxroLGFSh
miwAnjMtaHXs9lLX6M6mVJdjE6WW/ADF
=e9dY
-----END PGP SIGNATURE-----



More information about the bazaar mailing list