[MERGE] Add builtin subunit support.
John Arbash Meinel
john at arbash-meinel.com
Fri Mar 20 02:15:24 GMT 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins wrote:
> This adds builtin support for giving test output via subunit. I did have
> it as a plugin but its turned out to be a 'requirement' (easiest thing
> to use :P) for parallel testing, so I'd like to just make it part of the
> core testing facilities we have.
>
> -Rob
>
BB:tweak
Overall I'm fine with bringing this in. My only concern is this:
+ if subunit:
+ from bzrlib.tests import SubUnitBzrRunner
+ self.additional_selftest_args['runner_class'] =
SubUnitBzrRunner
^- If subunit isn't available you get an ugly import error trying to get
SubUnitBzrRunner.
I'd rather you wrap this into a BzrCommandError('--subunit requested but
could not find the python module subunit')
or something along those lines.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAknC/DwACgkQJdeBCYSNAAO+UgCfcD9gcsbOCSkZpvJzG2Z1sLae
tEMAoKoiJHPdGEGKSFhS2qjrIHyBhauH
=ej4j
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list