[MERGE] add shelve --destroy
Martin Pool
mbp at sourcefrog.net
Thu Mar 19 03:19:17 GMT 2009
2009/3/12 Aaron Bentley <aaron at aaronbentley.com>:
> James Westby wrote:
>> On Thu, 2009-03-12 at 11:26 +1000, Aaron Bentley wrote:
>>> This patch adds the option of destructive shelving, by doing shelve
>>> - --destroy.
>>
>> What do you think about making this "revert --interactive"?
>
> That sort of change needs to be done carefully, because there are
> differences between 'revert' and 'shelve --all'. Shelve deletes added
> files but revert just unversions them, and revert creates backups of
> modified files but shelve doesn't.
>
> This was a much more direct approach.
>
>> I realise it
>> would be more plumbing, but to me it is closer to the meaning, and
>> moving it to "revert" would make it clearer that changes were being
>> destroyed?
>
> Revert is actually less destructive than shelve --destroy, so I think
> the association might not be productive.
fwiw I was just wondering the same thing myself. Maybe we should
* have the revert help suggest using shelve or shelve --destroy instead
* eventually turn the backup-or-not behaviour into an option to
revert; it seems like opinions vary on which would be better
--
Martin <http://launchpad.net/~mbp/>
More information about the bazaar
mailing list