[MERGE][#109143] Support bzr+ssh://host/~/path

[Robert Collins]

On Thu, 2009-03-19 at 11:35 +1100, Martin Pool wrote:
> 2009/3/19 Andrew Bennetts <andrew.bennetts at canonical.com>:
> > I pretty surprised.  I thought the largest concern would be that with this
> > patch /~/ would stop users accessing files outside their home directory!
> > But no-one apart from me has even mentioned it.
> 
> It's reasonable to ask why
> 
>   bzr branch bzr+ssh://host/repos/foo bzr+ssh://host/~/repo/foo
> 
> would need to open two connections.  (I don't know if it gets by with
> just one at the moment, but it could.)

It does two, because we need two concurrent streams (from, and to), and
we don't have in-server-operations, which we might want at some point.

> > For bzr-over-tcp and bzr-over-http the client has no direct say in what
> > directories are being served.  The client gets whatever the server is
> > configured to give.  That's no different to e.g. plain HTTP.
> 
> So suppose we later get a bug asking why ~user doesn't work in
> bzr-over-tcp.  We'd then need to change the server to do expanduser
> when it maps the paths its given into local urls.  That seems
> redundant with doing it at the SSH level.

I think I agree, I haven't looked at the implementation, but I did
naively expect it to be purely server side, like it is for sftp - we
just need to pass relative rather than abspaths to the sftp server.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090319/9808e1f1/attachment.pgp