[MERGE][#109143] Support bzr+ssh://host/~/path

Martin Pool mbp at sourcefrog.net
Wed Mar 18 22:32:12 GMT 2009


2009/3/18 Andrew Bennetts <andrew.bennetts at canonical.com>:
> Martin Pool wrote:
> [...]
>>
>> It would be great to have that feature.  But if you're implementing it
>> by changing the ssh invocation method, then that does seem a bit
>> problematic: it may cause problems with configurations that check the
>> command, as you say, and it also means it won't work if bzr+ssh is
>> invoked over something other than ssh.
>
> I don't understand what you mean by “if bzr+ssh is invoked over something
> other than ssh”.  Perhaps you mean “other than /usr/bin/ssh from OpenSSH”,
> but if so I don't understand why you think that would be a problem?

I meant to say if "bzr+" is run over something other than ssh, like
tcp or http.  Considering those cases just seems to me to indicate
that this is being solved at the wrong layer.

> Oh, I think I see what you have in mind.  Presumably the server internally
> generates file:///~mbp/foo when the client asks for ~mbp/foo via the smart
> protocol (there's a ChrootTransport between the client and the remote's
> LocalTransport, but it doesn't matter to this discussion), so you're
> proposing that the LocalTransport should expand file:///~mbp to
> file:///home/mbp on the server.

Yes, that's what I meant.  This would even be somewhat useful in file urls.

> I suppose that's an option, although changing how we handle file:/// URLs
> makes me nervous.  We'd also lose the neat correspondence with sftp:// URLs,
> which AIUI don't expand ~mbp, just ~.

But we're already going to have a difference between ssh and sftp
URLs, which one would otherwise expect to be more similar.  Anyhow it
certainly seems possible that an sftp server would handle ~mbp.

-- 
Martin <http://launchpad.net/~mbp/>



More information about the bazaar mailing list