[MERGE] fix add in view-aware trees

[Ian Clatworthy]

This patch fixes a bad bug, https://bugs.launchpad.net/bzr/+bug/344708.
Basically 'add' is broken in formats supporting views, including
development-wt5 and the gc-chk formats in brisbane-core. I guess that
sort of thing happens when no-one reviews code before it lands. :-(

The fix itself is simple and obvious. It could easily go into a 1.13.1
version if we want users to begin testing filtered views in anger.

Most of this patch is new tests. I've expanded the tests so that the
blackbox add tests are executed for both a format not supporting views
and one supporting views. By design, most of the view handling is done
in the UI level (builtins.py) so this test multiplication is required
at that level and not just at the API level.

For good measure though, I also added a unit test for smart_add that
isn't strictly needed for this patch. It doesn't trigger this bug but
feel it's worth adding as it expands test coverage at the API level.

Ian C.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-in-wt5-bug.patch
Type: text/x-diff
Size: 6496 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090319/1f6c54b6/attachment.bin