Direction character on new progress bar
Martin Pool
mbp at sourcefrog.net
Wed Mar 18 08:38:24 GMT 2009
2009/3/18 John Arbash Meinel <john at arbash-meinel.com>:
> The latest version of the progress bar displays all sorts of information:
> [###################-] bzr+ssh > 6181kB 0kB/s | Running
> post_commit hooks [bzr-email] - Stage
>
> Of course, now the progress part takes up a lot of space, and pushes the
> info part to have less-and-less detail. This isn't terrible, but I had
> gotten used to seeing some of the object counts being shown, and I kind
> of miss that.
>
> Anyway, this is mostly about the new direction indicator. I'm not sure
> if < vs > is super clear about which way is read and write. (Inspecting
> the code > is reading.) Also, it seems like it would be better to put it
> on near the B/s portion, since that is the part that it is indicating.
> (It isn't saying we've uploaded a total of 5MB, just that the last 1kB/s
> was a write.)
>
> I don't have great suggestions, I just wanted to note that a couple bits
> could probably be made a little better.
Thanks for the feedback. Some of this stuff is hard to judge until
you see it really running, and in fact opinions vary depending on your
setup. I haven't tested it with bzr-svn or with super-wide terminals.
The directions are in fact the opposite of what jml reasonably
expected. :-) I like the idea of ^ for up (to the server) and v for
down, and nothing when it's unknown.
Do you think showing the scheme is worthwhile? I wanted to have at
least something there when it's getting started before the objects are
open.
We can make room for more of the counters by cutting out some of the
unnecessary levels of progress task. We should also, per a bug robert
opened, make sure not to truncate the counters.
--
Martin <http://launchpad.net/~mbp/>
More information about the bazaar
mailing list