[MERGE] Inventory.iter_just_entries()
Robert Collins
robert.collins at canonical.com
Wed Mar 18 00:21:29 GMT 2009
On Wed, 2009-03-18 at 09:34 +1000, Ian Clatworthy wrote:
> John Arbash Meinel wrote:
> > Ian Clatworthy wrote:
>
> >> I strongly agree that iter_just_entries() shouldn't be used without
> >> careful consideration in each case. That's part of the reason why
> >> I didn't make changes throughout the codebase to begin using it
> >> in this patch. I do feel however that generating data that isn't
> >> needed is generally wasteful so we need some way of avoiding that in
> >> the inventory API.
>
> >
> > I'm fine with it as a stop-gap, but I think the code that is using it
> > should actually be written differently. As there are limits to time and
> > energy, we can start with this until we get to the point of changing things.
>
> Is this bb:comment, tweak or approve? Perhaps I should make the API
> _iter_just_entries() for now to discourage usage outside of bzrlib?
I don't think this should be something other people use (as John says,
we don't really want to be using it ourselves even).
I'd say - land it in brisbane core with a big XXX beside it, to be
stripped before merging to bzr.dev.
-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090318/865c07e5/attachment.pgp
More information about the bazaar
mailing list