[MERGE] make sha1_provider a parameter to DirState()

Ian Clatworthy ian.clatworthy at internode.on.net
Tue Mar 17 22:38:03 GMT 2009


Martin Pool wrote:
> Martin Pool has voted tweak.
> Status is now: Conditionally approved
> Comment:
> Could you change it to SHA (in uppercase) which is consistent with other
> APIs?
> 
> +class DefaultSha1Provider(Sha1Provider):
> +    """A Sha1Provider that reads directly from the filesystem."""
> +
> +    def sha1(self, abspath):
> +        """Return the sha1 of a file given it's absolute path."""
> +        return osutils.sha_file_by_name(abspath)
> +
> +    def stat_and_sha1(self, abspath):

Which bit did you want changed? The class name? The methods? Both?
I'm pretty sure the functions in osutils use 'sha' - all in lowercase.

Ian C.



More information about the bazaar mailing list