[merge] remove test_remote tests for deprecated methods

[Robert Collins]

On Tue, 2009-03-17 at 20:52 +1100, Martin Pool wrote:
> So in the course of removing code for things deprecated prior to 1.6,
> I found I had to delete these two tests to make them pass.  But I'm
> not sure if that's really the best thing to do, and whether it'll
> cause trouble for old clients or in connecting to old servers.
> 
> I guess in general by removing deprecated code we will be breaking old
> clients that depend on it.   Keeping compatibility is good but we also
> want to be able to clean the codebase.
> 
> I don't have an immediate decision so I'll send this and see what you think...

What about the tests required the deletion? If it was using
get_revision_graph then a better approach is to just change the fallback
in remote.py to use self._get_revision_graph(); which calls the server
verb directly.

As it stands this patch removes important test coverage - testing that
we can talk to older servers.

So please -
 - keep the fallback tests as they were, but remove the expected
deprecations check - we don't need to trigger that.
 - make the client fallback to self._get_revision_graph rather than
self.get_revision_graph.

-Rob

bb:tweak
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090318/829d1c13/attachment.pgp