[RFC] can record.sha1 be None?

[Robert Collins]

"Yes" 

pydoc bzrlib.versionedfiles.ContentFactory

:ivar sha1: None, or the sha1 of the content fulltext.


On Mon, 2009-03-16 at 16:25 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> I'm working on making the GroupCompress factory stream support "Lazy"
> like we have for LazyKnit when delta_closure=True.
> 
> However, in the versionedfile interface tests, it asserts that if you
> pass include_delta_closure=False, then the records that are returned
> always have a valid sha1 sum.

Oh, thats a mistake. It should assert None | accurate.

> For now, I'm just changing the VF checking code, to allow it to either
> be None or the correct value. I just wanted to make sure that was ok.

Yup, its the intent.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090317/3fb257ee/attachment.pgp