[MERGE] faster check

John Arbash Meinel john at arbash-meinel.com
Mon Mar 16 15:22:40 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> The attached patch reduces the number of times that
> check walks each inventory from 4 to 1. The performance
> gain isn't large on pack repositories in the benchmarking
> I've done but it makes a big difference in chk repositories.
> 
> For example, the time for checking bzrtools on my laptop
> drops from 65 secs to 59 secs. Converting bzrtools to
> gc-chk255-big though gives a different story: the time drops
> from 67 secs to 31 secs.
> 
> Ian C.
> 

=== modified file 'bzrlib/inventory.py'
- --- bzrlib/inventory.py	2009-03-12 10:04:53 +0000
+++ bzrlib/inventory.py	2009-03-16 13:16:44 +0000
@@ -489,7 +489,7 @@
                 checker.repeated_text_cnt += 1
                 return

- -        mutter('check version {%s} of {%s}', tree_revision_id,
self.file_id)
+        #mutter('check version {%s} of {%s}', tree_revision_id,
self.file_id)
         checker.checked_text_cnt += 1
         # We can't check the length, because Weave doesn't store that
         # information, and the whole point of looking at the weave's

^- If this mutter is happening too often, just remove it.

Otherwise:
BB:tweak

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkm+bsAACgkQJdeBCYSNAAMDigCfRBVfn24nC6CLWtwET/5iaKUC
vOYAniWlI2POf7UmZKIf60/BLBlTmSx0
=ALKw
-----END PGP SIGNATURE-----



More information about the bazaar mailing list