bzr-svn question?

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Paul,

Fanelli, Paul wrote:>
> I got it to work, but I think what I want may be an enhancement.
> 
> I set the pre-revprop-change hook to just 'exit 0', to allow any change.
> I then set the 'override-svn-revprops = svn:author' in the
> .bazaar/subversion.conf file (I also tried setting it in the
> .bazaar/bazaar.conf file - and it seems to work there also).
> 
> Now the committer of the change is set in the svn:author property and I
> can see it when I run 'svn log'.
> 
> But the problem is that I am using pqm as an automated gatekeeper and I
> see the svn:author as 'SQA Auto Test <autotest at cuda>', which is the user
> running pqm (and not the actual user who made the change and submitted
> it to pqm). I guess this is correct and the intended behavior.
> 
> Would it be possible to extract out the bzr author information when
> bzr-svn commits the change to svn? The author of the change (the guy
> running the 'bzr pqm-submit' command) could use the --author option to
> set who the actual author of the change is?
Any chance you can file a bug report about allowing this ?

Cheers,

jelmer


>> -----Original Message-----
>> From: Jelmer Vernooij [mailto:jelmer at samba.org]
>> Sent: Friday, March 13, 2009 6:25 PM
>> To: Fanelli, Paul
>> Cc: bazaar at lists.canonical.com
>> Subject: Re: bzr-svn question?
>>
>> Hi Paul,
>>
>> On Fri, Mar 13, 2009 at 02:02:41PM -0400, Fanelli, Paul wrote:
>>> You can disregard my last email. I didn't understand how the svn
> hooks
>>> work.
>>> Now I think I better understand what's going on.  At least, some of
> it
>>> :-).
>>
>>
>>> My question is, how do you get the bzr:author property into svn via
> the
>>> bzr-svn plugin?
>>
>>
>>> I was able to get and set the svn:author property:
>>>             'svn propget svn:author -revprop -r xxxx'    to get it,
> and
>>>             'svn propset svn:author -revprop -r xxxx pfanelli'   to
> set
>>> it.
>>
>>
>>> In order for the property set to work, I had to add the following to
> the
>>> pre-revprop-change hook:
>>> if [ "$ACTION" = "M" -a "$PROPNAME" = "svn:author" ]; then
>>>     exit 0
>>> fi
>>> Now I just needed to find a place to run the svn propget and propset
>>> commands.  So I thought that the post-commit hook would be a good
> place.
>>> I added the following to post-commit:
>>> BZR_AUTHOR=`/usr/local/bin/svn propget bzr:author --revprop -r
> "$REV"
>>> "$REPOS"
>>> /usr/local/bin/svn propset svn:author --revprop -r "$REV"
> "$BZR_AUTHOR"
>>> "$REPOS"
>>> Once I wrote that, I realized that I would need to get the
> bzr:author
>>> into the commit.
>>> So, how do you get the bzr:author into the commit?
>>> Is this the right way to do this?
>> No, there isn't a need to bother with bzr:author here. You should just
>> need to set the right option (override-svn-revprops = svn:author IIRC)
>> in ~/.bazaar/subversion.conf, see the bzr-svn FAQ for details.
>>
>> Cheers,
>>
>> Jelmer
>>
>> --
>> Jelmer Vernooij <jelmer at samba.org> - http://jelmer.vernstok.nl/
>>  00:23:12 up 19 days,  6:36, 10 users,  load average: 1.77, 1.94, 2.25

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iJwEAQECAAYFAkm8PKUACgkQDLQl4QYPZuWzWQP7BcP06yOmR3SJXtAMcJSV/AaL
m1JJnmVsTMZ7evFJZxAES63bDTLo1E96ghsD3kVs1YlWv4Fo6twnS3a2OSnZ2j9y
geFRUUlFrz67zDciOAQsc/5D/izT06U4BQisy+37yTNLxaadNUaOW9uTt73S3Q83
jRtNf3TrHPO7pLAmCGU=
=DIMD
-----END PGP SIGNATURE-----