[MERGE] Support message bodies in bzr send

James Westby jw+debian at jameswestby.net
Thu Mar 12 01:28:19 GMT 2009


On Wed, 2009-03-11 at 17:49 +1000, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi all,
> This patch enables bzr send to accept an optional message body, and
> updates all the clients I could test (plus MAPI, because it looked dead
> simple) to support message bodies.

Looks pretty good to me, BB:tweak.

>          return self._run(submit_branch, revision, public_branch, remember,
>                           format, no_bundle, no_patch, output,
> -                         kwargs.get('from', '.'), mail_to, message)
> +                         kwargs.get('from', '.'), mail_to, message, body)

This change should be made to cmd_bundle_revisions as well.

>      def _compose(self, prompt, to, subject, attach_path, mime_subtype,
> -                 extension):
> +                 extension, body):

Should this be body=None, as you are passing it via **kwargs?

> -    def _get_compose_commandline(self, to, subject, attach_path):
> +    def _get_compose_commandline(self, to, subject, attach_path, body):

Same here.

> When body support has landed, I plan to also add a hook that can supply
> a body.

I look forward to this.

Thanks,

James




More information about the bazaar mailing list