[MERGE] Don't escape tildes

Jonathan Lange jml at mumak.net
Wed Mar 11 05:41:30 GMT 2009


On Wed, Mar 11, 2009 at 3:28 PM, Andrew Bennetts
<andrew.bennetts at canonical.com> wrote:
> Jonathan Lange wrote:
>> Sick of those irritating %7Es in your URLs? Then land this patch!
>
> bb:tweak
>
> [...]
>> === modified file 'bzrlib/urlutils.py'
>> --- bzrlib/urlutils.py        2009-01-17 01:30:58 +0000
>> +++ bzrlib/urlutils.py        2009-03-11 00:23:46 +0000
>> @@ -68,7 +68,7 @@
>>          relpath = relpath.encode('utf-8')
>>      # After quoting and encoding, the path should be perfectly
>>      # safe as a plain ASCII string, str() just enforces this
>> -    return str(urllib.quote(relpath))
>> +    return str(urllib.quote(relpath, safe='/~'))
>
> Why not use safe=_url_dont_escape_characters?

Surely you mean '/' + _url_dont_escape_characters. :-P



More information about the bazaar mailing list